[Console][LockableTrait] Remove parent::__construct() from the example which shows how to inject your own LockFactory #21530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e which shows how to inject your own LockFactory In this PR https://github.com/symfony/symfony-docs/pull/21507/files , when pointing out that constructor property promotion should not be used when injecting $lockFactory, I also wrongly introduced a `parent::__construct()` call. As in the current example attribute is used and the example command class is no longer extending `Symfony\Component\Console\Command\Command`, the call to the constructor of the parent class is actually wrong. I just wanted to fix this and to apologize for any inconvenience I caused with the back-and-forth related to this issue.
yceruto
approved these changes
Oct 23, 2025
xabbuh
approved these changes
Oct 23, 2025
|
@nicuserban No need to feel bad, we also didn't notice while reviewing. :) And thank you very much for sending the fix. 👍 |
|
No worries Nicolae. This is a minor issue and you fixed it very quickly. Thanks a lot! |
|
Thank you everyone for understanding and for reviewing this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR https://github.com/symfony/symfony-docs/pull/21507/files , when pointing out that constructor property promotion should not be used when injecting
$lockFactory, I also wrongly introduced aparent::__construct()call. As in the current example attribute is used and the example command class is no longer extendingSymfony\Component\Console\Command\Command, the call to the constructor of the parent class is actually wrong.I just wanted to fix this and to apologize for any inconvenience I caused with the back-and-forth related to this issue.